feat(sandbox): add a new sandbox for copilot and supports sandbox-runtime by Mossaka · Pull Request #4295 · github/gh-aw

Mossaka · 2025-11-18T17:40:55Z

introudces a new forntmatter syntax called sandbox and it allows users to configure different sandbox mechanisms to restrict the agent process.
this PR adds a sandbox-runtiem (srt) as a second option besides the awf (agentic worfklow firewall) to sandbox runtime and it adds some smoke tests.

Signed-off-by: Jiaxiao (mossaka) Zhou duibao55328@gmail.com

Copilot · 2025-11-18T19:35:47Z

@pelikhan I've opened a new pull request, #4299, to work on those changes. Once the pull request is ready, I'll request review from you.

pelikhan · 2025-11-18T21:13:23Z

@Mossaka The copilot task was just muscle memory... feel free to close that PR

Mossaka · 2025-11-18T22:29:57Z

as expected, there are some input parsing issues with srt. Let me fix that

pelikhan · 2025-11-19T00:28:48Z

Try adding label "Smoke" to run AW on this branch

Mossaka · 2025-11-19T09:10:32Z

Got this strange message from bubblewrap: " bwrap: loopback: Failed RTM_NEWADDR: Operation not permitted"

Mossaka · 2025-11-20T18:39:29Z

okay, the isolated SRT test for copilot CLI finally passed. Let me clean this up

Mossaka · 2025-11-21T23:03:34Z

@copilot please fix this issue https://github.com/githubnext/gh-aw/actions/runs/19582436139/job/56083451895#step:23:1

Copilot · 2025-11-21T23:03:47Z

@Mossaka I've opened a new pull request, #4524, to work on those changes. Once the pull request is ready, I'll request review from you.

Add support for Anthropic's Sandbox Runtime as an alternative sandboxing mechanism for Copilot-based agentic workflows. Key changes: - Add new sandbox types: 'default' (AWF) and 'sandbox-runtime' (SRT) - Add SRT configuration parsing from workflow frontmatter - Generate SRT wrapper script that initializes sandbox and passes env vars - Fix: Remove GITHUB_TOKEN and GH_TOKEN from SRT exports to prevent interference with COPILOT_GITHUB_TOKEN authentication - Fix: Normalize nil slices to empty slices for proper JSON serialization The SRT sandbox uses bubblewrap to create isolated environments with configurable network and filesystem restrictions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Add smoke test workflows to validate SRT functionality: - smoke-srt.md: Basic SRT smoke test using compiled workflow - smoke-srt-custom-config.md: SRT test with custom configuration - smoke-isolated-srt.yml: Hand-written SRT test for isolated testing - smoke-copilot-no-firewall.md: Copilot test without firewall 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Mossaka · 2025-11-26T21:34:26Z

@copilot please resolve all the linting issues

Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint config path] in [/home/runner/work/gh-aw/gh-aw] ...
  Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint config verify] in [/home/runner/work/gh-aw/gh-aw] ...
  Running [/home/runner/golangci-lint-1.64.8-linux-amd64/golangci-lint run] in [/home/runner/work/gh-aw/gh-aw] ...
  pkg/workflow/action_cache.go:1: : # github.com/githubnext/gh-aw/pkg/workflow [github.com/githubnext/gh-aw/pkg/workflow.test]
  Error: pkg/workflow/firewall_default_enablement_test.go:102:54: not enough arguments in call to enableFirewallByDefaultForCopilot
  	have (string, *NetworkPermissions)
  	want (string, *NetworkPermissions, *SandboxConfig)
  Error: pkg/workflow/firewall_default_enablement_test.go:178:54: not enough arguments in call to enableFirewallByDefaultForCopilot
  	have (string, *NetworkPermissions)
  	want (string, *NetworkPermissions, *SandboxConfig)
  Error: pkg/workflow/firewall_default_enablement_test.go:234:54: not enough arguments in call to enableFirewallByDefaultForCopilot
  	have (string, *NetworkPermissions)
  	want (string, *NetworkPermissions, *SandboxConfig) (typecheck)
  package workflow
  Error: pkg/workflow/imports_recursive_test.go:11:2: could not import github.com/githubnext/gh-aw/pkg/workflow (-: # github.com/githubnext/gh-aw/pkg/workflow [github.com/githubnext/gh-aw/pkg/workflow.test]
  Error: pkg/workflow/firewall_default_enablement_test.go:102:54: not enough arguments in call to enableFirewallByDefaultForCopilot
  	have (string, *NetworkPermissions)
  	want (string, *NetworkPermissions, *SandboxConfig)
  Error: pkg/workflow/firewall_default_enablement_test.go:178:54: not enough arguments in call to enableFirewallByDefaultForCopilot
  	have (string, *NetworkPermissions)
  	want (string, *NetworkPermissions, *SandboxConfig)
  Error: pkg/workflow/firewall_default_enablement_test.go:234:54: not enough arguments in call to enableFirewallByDefaultForCopilot
  	have (string, *NetworkPermissions)
  	want (string, *NetworkPermissions, *SandboxConfig)) (typecheck)
  	"github.com/githubnext/gh-aw/pkg/workflow"
  	^
  
  Error: issues found
  Ran golangci-lint in 10387ms

Copilot · 2025-11-26T21:34:36Z

@Mossaka I've opened a new pull request, #4887, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

This PR introduces a new sandbox mechanism called Sandbox Runtime (SRT) as an alternative to the existing AWF (Agent Workflow Firewall). It adds support for Anthropic's @anthropic-ai/sandbox-runtime package to provide runtime sandboxing capabilities for the Copilot engine.

Key changes:

Adds new sandbox frontmatter field supporting "default" (AWF) and "sandbox-runtime" (SRT) options
Implements SRT configuration generation and validation with network/filesystem controls
Modifies Copilot engine to support local npm installation for SRT compatibility
Adds smoke test workflows to validate SRT functionality

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`pkg/workflow/sandbox.go`	New file implementing SRT configuration types, validation, and JSON generation logic
`pkg/workflow/nodejs.go`	Extended npm installation to support both global and local scopes for SRT compatibility
`pkg/workflow/frontmatter_extraction.go`	Added sandbox config extraction from workflow frontmatter with support for both string and object formats
`pkg/workflow/firewall_default_enablement_test.go`	Updated tests to pass sandbox config parameter to firewall enablement function
`pkg/workflow/firewall.go`	Modified firewall auto-enablement to respect SRT mutual exclusivity
`pkg/workflow/copilot_engine.go`	Major changes to support SRT: local Copilot installation, SRT setup steps, wrapper script generation
`pkg/workflow/compiler.go`	Integrated sandbox validation into compilation workflow
`pkg/parser/schemas/main_workflow_schema.json`	Added JSON schema definition for the new sandbox configuration field
`.github/workflows/smoke-srt.md`	New smoke test workflow with custom SRT configuration
`.github/workflows/smoke-srt.lock.yml`	Generated workflow file for SRT smoke test
`.github/workflows/smoke-srt-custom-config.md`	Additional smoke test with extensive custom domain configuration
`.github/workflows/smoke-isolated-srt.yml`	Isolated SRT test workflow for validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-26T21:55:13Z

@@ -0,0 +1,116 @@
+---


The spelling "introudces" in the PR description should be "introduces".

Copilot · 2025-11-26T21:55:13Z

@@ -0,0 +1,116 @@
+---


The spelling "forntmatter" in the PR description should be "frontmatter".

Copilot · 2025-11-26T21:55:13Z

@@ -0,0 +1,116 @@
+---


The spelling "worfklow" in the PR description should be "workflow".

Copilot · 2025-11-26T21:55:14Z

@@ -0,0 +1,116 @@
+---


The spelling "runtiem" in the PR description should be "runtime".

Mossaka force-pushed the mossaka/srt branch from 68c0d90 to 76f6a83 Compare November 18, 2025 17:41

Mossaka added the test-srt label Nov 18, 2025

pelikhan reviewed Nov 18, 2025

View reviewed changes

Comment thread .github/workflows/smoke-srt-custom-config.md

Comment thread .github/workflows/smoke-srt-custom-config.md

Comment thread .github/workflows/smoke-srt.md Outdated

Copilot AI mentioned this pull request Nov 18, 2025

feat: support sandbox configuration via shared workflow imports #4299

Closed

Mossaka added test-srt and removed test-srt labels Nov 18, 2025

Mossaka added test-srt and removed test-srt labels Nov 19, 2025

Mossaka added test-srt and removed test-srt labels Nov 20, 2025

Copilot AI mentioned this pull request Nov 21, 2025

fix(copilot): add --log-dir flag for sandbox mode to enable log parsing #4524

Closed

Mossaka added test-srt and removed test-srt labels Nov 22, 2025

Mossaka and others added 2 commits November 26, 2025 21:25

Copilot AI mentioned this pull request Nov 26, 2025

fix: resolve linting issues for sandbox feature #4887

Merged

fix: resolve linting issues for sandbox feature (#4887)

19c9cda

Copilot AI reviewed Nov 26, 2025

View reviewed changes

Merge branch 'main' into mossaka/srt

04039c3

github-actions Bot mentioned this pull request Nov 27, 2025

[docs] Add safe-outputs.messages customization documentation #4914

Merged

Conversation

Mossaka commented Nov 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 18, 2025

Uh oh!

pelikhan commented Nov 18, 2025

Uh oh!

Mossaka commented Nov 18, 2025

Uh oh!

pelikhan commented Nov 19, 2025

Uh oh!

Mossaka commented Nov 19, 2025

Uh oh!

Mossaka commented Nov 20, 2025

Uh oh!

Mossaka commented Nov 21, 2025

Uh oh!

Copilot AI commented Nov 21, 2025

Uh oh!

Mossaka commented Nov 26, 2025

Uh oh!

Copilot AI commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants